Skip to content

Deprecate Mage_Sales_Model_Entity_Quote_Item_Collection#5323

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/remove-mage-sales-model-collection
Draft

Deprecate Mage_Sales_Model_Entity_Quote_Item_Collection#5323
Copilot wants to merge 2 commits intomainfrom
copilot/remove-mage-sales-model-collection

Conversation

Copy link
Contributor

Copilot AI commented Mar 14, 2026 •
edited
Loading

Mage_Sales_Model_Entity_Quote_Item_Collection is a stale EAV-era remnant. It contains debug profilers (TEST1/TEST2) and calls $item->importCatalogProduct() which doesn't exist. The actual implementation has long lived in Mage_Sales_Model_Resource_Quote_Item_Collection.

Changes

  • Model/Entity/Quote/Item/Collection.php: Replace ~130 lines of broken EAV logic with a deprecated stub extending the correct resource collection — matching the existing pattern of Mage_Sales_Model_Mysql4_Quote_Item_Collection.
// Before: broken EAV collection with TEST profilers and non-existent method calls
class Mage_Sales_Model_Entity_Quote_Item_Collection extends Mage_Eav_Model_Entity_Collection_Abstract { ... }

// After: deprecated alias preserving backward compatibility
/** @deprecated use Mage_Sales_Model_Resource_Quote_Item_Collection */
class Mage_Sales_Model_Entity_Quote_Item_Collection extends Mage_Sales_Model_Resource_Quote_Item_Collection {}
Original prompt

This section details on the original issue you should resolve

<issue_title>[FEAT] Mage_Sales_Model_Entity_Quote_Item_Collection should not exist</issue_title>
<issue_description>These profilers are kinda suspect:

magento-lts/app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php

Lines 56 to 58 in 1efade8

Varien_Profiler::start('TEST1: ' . __METHOD__);
$productCollection = $this->_getProductCollection();
Varien_Profiler::stop('TEST1: ' . __METHOD__);

and this function doesn't exist:

magento-lts/app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php

Line 95 in 1efade8

$item->importCatalogProduct($itemProduct);

Probably a leftover from when Sales/Quote was an EAV.</issue_description>

Comments on the Issue (you are @copilot in this section)

@sreichel PR to remove?

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@addison74
Deprecate Mage_Sales_Model_Entity_Quote_Item_Collection
89cc19b 
Co-authored-by: addison74 <8360474+addison74@users.noreply.github.com>
Copilot AI changed the title [WIP] [FEAT] Remove Mage_Sales_Model_Entity_Quote_Item_Collection Deprecate Mage_Sales_Model_Entity_Quote_Item_Collection Mar 14, 2026
Copilot AI requested a review from addison74 March 14, 2026 07:39
@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Mar 14, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 14, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2026 •
edited
Loading

Test Results

970 tests  ±0   962 ✅ ±0   16s ⏱️ -1s
214 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 89cc19b. ± Comparison against base commit a793123.

♻️ This comment has been updated with latest results.

@sreichel
Copy link
Contributor

sreichel commented Mar 15, 2026

Remove it?

@fballiano fballiano mentioned this pull request Mar 15, 2026
Merged
5 tasks
@Hanmac
Copy link
Contributor

Hanmac commented Mar 16, 2026

@sreichel probably remove everything like @fballiano did?

@sreichel
Copy link
Contributor

sreichel commented Mar 18, 2026

@Hanmac i dont know what Fab removed, but feel free to remove useless code.

@Hanmac
Copy link
Contributor

Hanmac commented Mar 18, 2026

@sreichel it's these MRs:

its more or less removal of all the old stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addison74 addison74 Awaiting requested review from addison74

At least 2 approving reviews are required to merge this pull request.

Assignees

@addison74 addison74

Copilot code review Copilot

Labels

Component: Sales Relates to Mage_Sales

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT] Mage_Sales_Model_Entity_Quote_Item_Collection should not exist

4 participants

@sreichel @Hanmac @addison74